Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS idents to match ECMA 5.1 #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update JS idents to match ECMA 5.1 #174

wants to merge 1 commit into from

Conversation

JasonBarnabe
Copy link

No description provided.

@JasonBarnabe JasonBarnabe mentioned this pull request Jun 28, 2014
Open
@JasonBarnabe
Copy link
Author

@korny can you look at this?

@korny
Copy link
Member

korny commented Apr 22, 2015

Problem is, your solution would only work with Ruby 1.9+. I plan to drop 1.8 support, but not before CodeRay 2.

@korny korny added this to the Future milestone Apr 22, 2015
@korny korny self-assigned this Apr 22, 2015
@glebm
Copy link

glebm commented Dec 3, 2018 •
edited
Loading

I think it's safe to drop Ruby 1.8 at this point.
Ruby 1.8 is not even supported for security fixes.

Currently, 2.3 is the oldest Ruby version still supported for security fixes (until April 2019)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@korny korny

Labels
Request Scanners
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonBarnabe @korny @glebm